[CALCITE-3592] Implement BITNOT scalar function #3983
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
normanj-bitquill
commented
Sep 26, 2024
normanj-bitquill
commented
- Implemented the BITNOT scalar function as a standard function
- Supports integer and binary arguments
- Returns NULL if the argument is NULL
* Implemented the BITNOT scalar function as a standard function * Supports integer and binary arguments * Returns NULL if the argument is NULL
mihaibudiu
approved these changes
Sep 26, 2024
| @@ -15738,6 +15738,29 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) { | |||
| true); | |||
| } | |||
|
|
|||
| @Test void testBitNotScalarFunc() { | |||
| final SqlOperatorFixture f = fixture(); | |||
| f.setFor(SqlStdOperatorTable.BITXOR, VmName.EXPAND); | |||
There was a problem hiding this comment.
XOR?
How about a failing test with DECIMAL?
There was a problem hiding this comment.
Interesting that using XOR had not impact on the tests. Fixed now.
Also added a test for BITNOT(DECIMAL).
There was a problem hiding this comment.
I think that setFor is just decorative
|
caicancai
reviewed
Sep 29, 2024
| @@ -15738,6 +15738,35 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) { | |||
| true); | |||
| } | |||
|
|
|||
| @Test void testBitNotScalarFunc() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.