[CALCITE-6265] Type coercion is failing for numeric values in prepared statements (follow-up) #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tindzk , could you please take a look at this PR, which addresses some issue from CALCITE-6265? (more info in the Jira ticket) |
|
The changes look good to me and your approach is a lot cleaner. Thanks for looking into it. |
asolimando
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM, left only a small comment, thanks @rubenada for looking into this
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java
Outdated
Show resolved
Hide resolved
rubenada
force-pushed
the
CALCITE-6265_followUp
branch
from
f3b8a78
to
2a03f67
Compare
|
Thanks for the feedback. I have created CALCITE-6366, and reference it on the PR code. |
mihaibudiu
reviewed
Apr 15, 2024
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
Show resolved
Hide resolved
|
rubenada
added
the
LGTM-will-merge-soon
…d statements Address some issues on the original patch
rubenada
force-pushed
the
CALCITE-6265_followUp
branch
from
bee5c5c
to
680694f
Compare
mihaibudiu
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some issues on the original patch (4e6a320 , via PR #3687 )
See details in CALCITE-6265