[CALCITE-6345] Intervals with more than 100 years are not supported #3743
Conversation
|
Does anyone want to comment on this PR? |
| @@ -870,8 +870,6 @@ public void subTestIntervalYearNegative() { | |||
|
|
|||
| // Field value out of range | |||
| // (default, explicit default, alt, neg alt, max, neg max) | |||
| f.wholeExpr("INTERVAL '100' YEAR") | |||
There was a problem hiding this comment.
A small question, whether to put the supported cases separately in an executable single test instead of deleting them directly
There was a problem hiding this comment.
Is the suggestion to convert these into positive tests? I can do that.
There was a problem hiding this comment.
Yes, recommend keeping the test case as positive tests
There was a problem hiding this comment.
I have added the removed tests back as positive tests, but I have kept them in the same place in the code.
I could move them to separate functions too if that's clearer.
Signed-off-by: Mihai Budiu <[email protected]>
No description provided.