[CALCITE-6343] Fix AS alias operator stripping MEASUREness from measures #3741
Conversation
barrkel
force-pushed
the
bk-upstream-fix-as-measure-type
branch
2 times, most recently
from
8cd7dd4
to
622a340
Compare
core/src/test/java/org/apache/calcite/sql/type/RelDataTypeSystemTest.java
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
Outdated
Show resolved
Hide resolved
|
test failed： |
barrkel
force-pushed
the
bk-upstream-fix-as-measure-type
branch
from
622a340
to
b41526d
Compare
…lias operator When inferring the return type of an operator application, don't unwrap MEASURE types if the operator is an AS alias.
barrkel
force-pushed
the
bk-upstream-fix-as-measure-type
branch
from
b41526d
to
2975087
Compare
|
I saw a failure with |
|
| if (opBinding.getOperator().kind != SqlKind.AS | ||
| && isMeasure(returnType) | ||
| && returnType.getMeasureElementType() != null) { | ||
| returnType = returnType.getMeasureElementType(); |
There was a problem hiding this comment.
The checkerframework failure below does seem related to your change
There was a problem hiding this comment.
It's related to the change you asked me to make on your code, removing the not-null assertion.
There was a problem hiding this comment.
Might need to add it back. Seems like it's messing something up.
There was a problem hiding this comment.
Also I've found it can be a time-saver to try re-building before pushing new changes.
|
This looks easy to fix, if you can handle the checker errors we could merge this in time for 1.38 |
…lias operator When inferring the return type of an operator application, don't unwrap MEASURE types if the operator is an AS alias. Close apache#3741
…lias operator When inferring the return type of an operator application, don't unwrap MEASURE types if the operator is an AS alias. Close apache#3741
When inferring the return type of an operator application, don't unwrap MEASURE types if the operator is an AS alias.