Update javadoc for SqlTypeName#allowsPrecScale method #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use |
mihaibudiu
approved these changes
Nov 26, 2023
|
If you can change your commit message by prefixing it with [MINOR] and if you rebase on main I think we can merge this. |
|
@JiajunBernoulli @mihaibudiu There is no convention in Calcite that we must prefix such changes with "[MINOR]", it's just personal taste, see latest discussion in CALCITE-5974. |
|
This still looks like it needs rebasing so the Druid tests pass, then we can merge. |
zhujiang614
force-pushed
the
fix_allowsPrecScale_typo
branch
from
af42567
to
6b2b0c1
Compare
|
I have changed the commit message and submit again, thank you for your suggestions |
|
Kudos, SonarCloud Quality Gate passed!
|
mihaibudiu
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update javadoc for SqlTypeName#allowsPrecScale method