[CALCITE-6014] Create a SqlOperatorFixture that parses, unparses, and… #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
force-pushed
the
issue6014
branch
from
0edd354
to
86cc1c7
Compare
|
It would be great if someone could review this PR. It essentially adds a few hundred tests for the parser/unparser by reusing all the SqlOperatorTest tests. It caught at least 8 bugs already, most of which I have fixed. Going forward, it may make it much easier to write unparser tests. |
rubenada
reviewed
Oct 13, 2023
core/src/test/java/org/apache/calcite/test/SqlOperatorUnparseTest.java
Outdated
Show resolved
Hide resolved
rubenada
reviewed
Oct 13, 2023
core/src/test/java/org/apache/calcite/test/SqlOperatorUnparseTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @mihaibudiu for moving this forward, I think this is a good idea to unveil bugs. |
… then parses again before executing Signed-off-by: Mihai Budiu <[email protected]>
mihaibudiu
commented
Oct 13, 2023
|
I hope I have addressed the comments. I have optimistically squashed the commits to make this ready to merge. |
|
Kudos, SonarCloud Quality Gate passed!
|
rubenada
added
the
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… then parses again before executing
The code contains disabled tests for 5 bugs; these bugs have been all reported, and 3 already have PRs fixing them.
These disabled tests should be removed once the fixes are merged.
The change to SqlOperatorFixtureImpl also fixes a small and obvious bug.