Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6001] Add dialect-specific character sets for encoding string literals #3425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CALCITE-6001] Add dialect-specific character sets for encoding string literals #3425

wants to merge 1 commit into from

Conversation

tanclary
Copy link
Contributor

@tanclary tanclary commented Sep 12, 2023 •
edited
Loading

No description provided.

@tanclary tanclary changed the title [CALCITE-6001] Add useUtf8AsDefaultCharset flag to SqlConformanceEnum… [CALCITE-6001] Add charset to parser config Sep 16, 2023
@tanclary tanclary force-pushed the 6001-dialect-charset branch 2 times, most recently from 6826e5b to a89ee21 Compare October 18, 2023 23:19
@tanclary tanclary marked this pull request as ready for review October 18, 2023 23:31
@tanclary tanclary changed the title [CALCITE-6001] Add charset to parser config [CALCITE-6001] Add dialect-specific character sets for encoding string literals Oct 18, 2023
@tanclary tanclary force-pushed the 6001-dialect-charset branch 4 times, most recently from 505fefe to 0f70a35 Compare October 19, 2023 19:20
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

93.9% 93.9% Coverage
0.0% 0.0% Duplication

@julianhyde
Copy link
Contributor

Since literals also exist in source SQL, and intermediate SqlNode and RexNodes, you should change the summary to make clear that this relates to generating SQL. 'JDBC adapter should...' is one way.

@tanclary tanclary mentioned this pull request Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianhyde julianhyde Awaiting requested review from julianhyde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanclary @julianhyde