[CALCITE-5999] DECIMAL literals are sometimes unparsed looking as DOUBLE literals #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,7 +90,7 @@ public boolean isExact() { | |||
| @Override public String toValue() { | |||
| BigDecimal bd = getValueNonNull(); | |||
| if (isExact) { | |||
| return getValueNonNull().toString(); | |||
| return getValueNonNull().toPlainString(); | |||
There was a problem hiding this comment.
Why not use bd.toPlainString()?
And the bd should be final.
There was a problem hiding this comment.
Good point, I pushed these changes. Since the PR is so small I have already squashed the two commits.
mihaibudiu
force-pushed
the
issue5999
branch
from
1e58014
to
bda8e20
Compare
…LE literals Signed-off-by: Mihai Budiu <[email protected]>
mihaibudiu
force-pushed
the
issue5999
branch
from
bda8e20
to
6408304
Compare
|
Kudos, SonarCloud Quality Gate passed! |
JiajunBernoulli
approved these changes
Sep 17, 2023
JiajunBernoulli
added
the
LGTM-will-merge-soon
mihaibudiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.