[CALCITE-5992] Avoid comparing root Relsubset's TraitSet with itself #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
LakeShen
reviewed
Sep 10, 2023
| @@ -565,6 +565,9 @@ void ensureRootConverters() { | |||
| } | |||
| } | |||
| for (RelSubset subset : root.set.subsets) { | |||
| if (subset == root) { | |||
There was a problem hiding this comment.
I'm not sure whether the logic of these lines of code is correct, could you add a unit test for this logic?
asdfgh19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: CALCITE-5992
Since VolcanoPlanner#root will definitely exist in the subsets collection of the Relset related to it, we can skip the comparison between the root Relsubset and itself.