Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-5938] Update HSQLDB to Version 2.7.2 (using JDK8 JAR, default supports JDK11+) #3392

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

tanclary
Copy link
Contributor

@tanclary tanclary commented Aug 22, 2023

Had to use special classifier syntax to use alternative JAR that supports JDK8
@shalaniw

@tanclary tanclary force-pushed the 5938-hsqldb branch 2 times, most recently from 4ca0319 to 62a2ed5 Compare August 22, 2023 18:22
@tanclary tanclary changed the title [CALCITE-5938] Update HSQLDB to Version 2.7.1 [CALCITE-5938] Update HSQLDB to Version 2.7.2 Sep 14, 2023
@julianhyde
Copy link
Contributor

@tanclary Well done finding the special classifier syntax. I spent a long time searching and never found it.

Do you think it would work if you made the change only in bom/build.gradle.kts? That file is the one and only place where dependencies are declared; all other places are just references to that.

@tanclary
Copy link
Contributor Author

@tanclary Well done finding the special classifier syntax. I spent a long time searching and never found it.

Do you think it would work if you made the change only in bom/build.gradle.kts? That file is the one and only place where dependencies are declared; all other places are just references to that.

Ah good idea, will update it and see how the CI reacts.

@tanclary
Copy link
Contributor Author

@julianhyde Tried the change you suggested, seems to be failing as it tries to call ".version" on the classifier which of course doesn't exist. Going to revert.

@julianhyde
Copy link
Contributor

Thanks for trying the BOM update.

+1 to your original PR, but please add comments for why the '::jdk8' suffix is necessary. The commit message would seem to be a good place.

@tanclary tanclary changed the title [CALCITE-5938] Update HSQLDB to Version 2.7.2 [CALCITE-5938] Update HSQLDB to Version 2.7.2 (using JDK8 JAR, default supports JDK11+) Sep 15, 2023
@tanclary
Copy link
Contributor Author

@julianhyde Done. Thanks for your help.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tanclary tanclary merged commit f136c13 into apache:main Sep 15, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants