Support detection of bthread mutex and FastMutex deadlock caused by double lock #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenBright
changed the title
|
这个是否会影响性能？ |
chenBright
force-pushed
the
bthread_deadlock_detection
branch
6 times, most recently
from
2daa334
to
da030ca
Compare
chenBright
force-pushed
the
bthread_deadlock_detection
branch
from
da030ca
to
b01486b
Compare
之前的实现不会影响性能，但是没用原子变量没法保证正确性。现在用原子变量实现后会导致性能退化，MutexTest.performance测试发现锁的平均运行时间慢了50%左右，所以该功能只作为debug手段，默认关闭，只有编译bRPC库时定义了DEBUG_MUTEX宏才会开启该功能。 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
加锁成功记录下拥有锁的bthread/pthread id，如果在同一个bthread/pthread，就可以检测到在同一个bthread/pthread中重复加锁。
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: