Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set streaming engine option to fix V1 tests #33100

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

ahmedabu98
Copy link
Contributor

No description provided.

@ahmedabu98
Copy link
Contributor Author

Copy link
Contributor

@claudevdm claudevdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.95%. Comparing base (785ec07) to head (ea7eb65).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33100      +/-   ##
============================================
+ Coverage     58.90%   58.95%   +0.04%     
- Complexity     3112     3150      +38     
============================================
  Files          1131     1133       +2     
  Lines        174605   174569      -36     
  Branches       3357     3351       -6     
============================================
+ Hits         102850   102915      +65     
+ Misses        68401    68307      -94     
+ Partials       3354     3347       -7     
Flag Coverage Δ
java 70.26% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm
Copy link
Contributor

Looks like PreCommit Xlang Generated Transforms is hung, it seems unrelated to this PR though. I'm going to cancel/rerun, but also optimistically merge so we can get the release branch going. If needed, we can cherry-pick in another fix

@damccorm damccorm merged commit cb06b1b into apache:master Nov 13, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants