-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set streaming engine option to fix V1 tests #33100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33100 +/- ##
============================================
+ Coverage 58.90% 58.95% +0.04%
- Complexity 3112 3150 +38
============================================
Files 1131 1133 +2
Lines 174605 174569 -36
Branches 3357 3351 -6
============================================
+ Hits 102850 102915 +65
+ Misses 68401 68307 -94
+ Partials 3354 3347 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like |
No description provided.