Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add histogram to metrics container #33043

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Nov 7, 2024

Add histogram to metrics container. The histogram representation here is the DataflowHistogramValue representation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 2 times, most recently from 7ba2869 to 44cf182 Compare November 7, 2024 22:08
@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 5 times, most recently from 7db8de1 to 2f9125a Compare November 11, 2024 17:33
@Naireen
Copy link
Contributor Author

Naireen commented Nov 11, 2024

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 11, 2024

Run Go PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 3 times, most recently from 3518bf8 to e0dcf4c Compare November 12, 2024 04:23
@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java_Pulsar_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java_PVR_Prism_Loopback PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java_IOs_Direct PreCommit

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (2488ca1) to head (e0dcf4c).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33043      +/-   ##
============================================
+ Coverage     58.90%   59.00%   +0.10%     
  Complexity     3112     3112              
============================================
  Files          1131     1132       +1     
  Lines        174613   174997     +384     
  Branches       3357     3357              
============================================
+ Hits         102856   103265     +409     
+ Misses        68403    68378      -25     
  Partials       3354     3354              
Flag Coverage Δ
python 81.57% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from e0dcf4c to 377f753 Compare November 12, 2024 05:54
@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java PreCommit

@Naireen Naireen marked this pull request as ready for review November 12, 2024 16:51
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant