-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yaml] Fix examples catalog tests #33027
Conversation
R: @robertwb |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
08cb64b
to
f6f87ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@@ -876,8 +877,10 @@ def _parse_window_spec(spec): | |||
return beam.WindowInto(window_fn) | |||
|
|||
@staticmethod | |||
@beam.ptransform_fn | |||
@maybe_with_exception_handling_transform_fn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect this to every have errors (that we'd want to ignore)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only case for Python I can think of is if it is somehow not JSON parseable (Possibly a custom provider upstream that does not return Row)
For Java, I could see there being other issues (for starters, doesn't ERROR throw and exception when it logs?)
Regardless, this change was mostly for making it easier to hot-swap LogForTesting in example pipelines that define error_handling Write transforms. But I could also create a custom Log transform within the examples test file if you think that makes more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's fine.
Looks like this needs a rebase. |
a53a56a
to
38d363c
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
38d363c
to
a6b7af0
Compare
This PR fixes a few tests in the YAML examples catalog, including enabling the Spanner tests which were previously excluded.
There are a couple of organizational changes including separating error_handling into a separate file. This was to allow LogForTesting to use the error_handling framework which is handy for examples tests that replace WriteTo transforms with LogForTesting ad-hoc that consume an error output of an upstream WriteTo transform.
This is also a prereq to #32289
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.