Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pydoc Precommit #32747

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Fix Pydoc Precommit #32747

merged 5 commits into from
Oct 10, 2024

Conversation

jrmccluskey
Copy link
Contributor

Updates the Pydoc precommit script to work on 3.9 with updated dependencies, process new doc formatting correctly. Will need a second pass to clean up some warnings, but this unblocks the 2.60.0 release pydoc generation

Fixes #32728


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey
Copy link
Contributor Author

@jrmccluskey
Copy link
Contributor Author

R: @liferoad @Abacn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liferoad
Copy link
Collaborator

Xlang keeps failing now. @Polber

@liferoad liferoad merged commit 5f4342b into master Oct 10, 2024
98 of 99 checks passed
@Abacn Abacn deleted the pydocUpdate branch October 11, 2024 20:32
Abacn pushed a commit to Abacn/beam that referenced this pull request Oct 11, 2024
Fix Pydoc Precommit

Co-authored-by: Jack McCluskey <[email protected]>
Abacn added a commit that referenced this pull request Oct 12, 2024
Fix Pydoc Precommit

Co-authored-by: liferoad <[email protected]>
Co-authored-by: Jack McCluskey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PythonDocs fail to build after moving to Python3.9
3 participants