Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize building wheels per language version #32297

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 23, 2024

This will greatly speed up our time to release (now docker artifacts will be the bottleneck, though we could do something similar for them if needed

  • Example of this running on a non-rc - takes ~1 hour
  • Example of this running on a (fake) RC - RC faked with a56dd56 - takes <2.5 hours.
  • Example of running without this change on a non-RC - takes 5 hours (admittedly on the high end of what is normal in my experience)
  • Example of running without this change on an RC - takes 7 hours

Fixes #32217


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Aug 23, 2024
@damccorm damccorm marked this pull request as ready for review August 23, 2024 11:44
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor Author

damccorm commented Aug 23, 2024

cc/ @lostluck since this could impact RC creation

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit 1e80815 into master Aug 23, 2024
34 checks passed
@damccorm damccorm deleted the users/damccorm/parallel_wheels branch October 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: build_wheels workflow takes too long for release candidates
2 participants