Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix row ranges issue in Bigtable Read. #31990

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Jul 25, 2024

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Issue was on end of range, where we would send a request to the server asking for rows in range X->X. Both Xs being identical resulted in a "invalid range, start needs to be smaller than end" error from server.

@ron-gal ron-gal marked this pull request as ready for review July 25, 2024 19:09
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @shunping for label io.
R: @mutianf for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@m-trieu m-trieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test we can add to ensure it's fixed and guarded from future regressions?

@ron-gal
Copy link
Contributor Author

ron-gal commented Jul 29, 2024

Is there a unit test we can add to ensure it's fixed and guarded from future regressions?

Done :)

@ron-gal ron-gal requested a review from m-trieu July 29, 2024 22:00
Copy link
Contributor

@m-trieu m-trieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Java

Copy link
Contributor

R: @robertwb for final approval

@robertwb robertwb changed the title Fix row ranges issue Fix row ranges issue in Bigtable Read. Jul 31, 2024
@robertwb
Copy link
Contributor

Could you update the description to indicate what exactly the issue was? (Does it merit a change to the top level CHANGES.md (which become release notes)?)

@ron-gal
Copy link
Contributor Author

ron-gal commented Jul 31, 2024

Could you update the description to indicate what exactly the issue was? (Does it merit a change to the top level CHANGES.md (which become release notes)?)

Done.
I don't think it merits a change to CHANGES.md.

@robertwb robertwb merged commit 346011b into apache:master Jul 31, 2024
18 checks passed
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants