Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Version to 1.22.4 #31747

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

jrmccluskey
Copy link
Contributor

Bumps Go version across Beam to 1.22.4 as per https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#update-go-version-used-for-container-builds


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey jrmccluskey marked this pull request as ready for review July 2, 2024 15:27
@jrmccluskey
Copy link
Contributor Author

R: @lostluck

I think this should update everything? Totally down to hold this until after the 2.58.0 cut if you have a plan in mind for updating the Go version later

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind I just missed it. Thanks!

@jrmccluskey jrmccluskey merged commit 8e11d0a into apache:master Jul 2, 2024
26 checks passed
@lostluck
Copy link
Contributor

lostluck commented Jul 2, 2024

The go version change that needs more care is updating the minimum version in the module, but this is seperable. Thanks!

@jrmccluskey
Copy link
Contributor Author

Yes I was specifically targeting the infra version, I'll leave determining the minimum Go version for the SDK to you

@jrmccluskey jrmccluskey mentioned this pull request Jul 2, 2024
3 tasks
@Abacn Abacn mentioned this pull request Jul 3, 2024
3 tasks
@jrmccluskey jrmccluskey mentioned this pull request Jul 9, 2024
3 tasks
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants