Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jdbc Resource managers to manage various databases in tests. #27698

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

pranavbhandari24
Copy link
Contributor

Add Jdbc Resource managers to manage various databases in tests.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jul 26, 2023
@pranavbhandari24
Copy link
Contributor Author

R: @Abacn, @kennknowles, @johnjcasey

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #27698 (1c85322) into master (505d7c1) will decrease coverage by 0.01%.
Report is 38 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27698      +/-   ##
==========================================
- Coverage   70.93%   70.92%   -0.01%     
==========================================
  Files         861      861              
  Lines      104806   104808       +2     
==========================================
- Hits        74344    74338       -6     
- Misses      28904    28912       +8     
  Partials     1558     1558              
Flag Coverage Δ
python 80.00% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor

Abacn commented Jul 27, 2023

Run It_Framework PreCommit

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to #27715 github action trigger not working properly. Tested locally (./gradlew 🇮🇹jdbc:build) passed:

image

@pranavbhandari24
Copy link
Contributor Author

Run Java_Azure_IO_Direct PreCommit

@pranavbhandari24
Copy link
Contributor Author

Run Kotlin_Examples PreCommit

@Abacn
Copy link
Contributor

Abacn commented Jul 28, 2023

Run SQL_Java17 PreCommit

@Abacn Abacn merged commit 314750b into apache:master Jul 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants