Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate nullness errors from GenerateSequence #23744

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

kennknowles
Copy link
Member

The inconsistent nullness annotations on the autovalue for GenerateSequence cause nondeterministic code generation. This in turn made it impossible to get to the point of reproducing a flake I was tracking down.

This PR simply eliminates the existing nullness errors and makes this particular file consistent, removing the suppression of the type checker.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Oct 19, 2022
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor

LGTM

@johnjcasey johnjcasey merged commit 15ab500 into apache:master Oct 21, 2022
@reuvenlax
Copy link
Contributor

Unfortunately this PR seems to have broken tests :( Somehow it's caused AutoValue to decide that maxReadTime was a required parameter, which was not the case before).

@kennknowles
Copy link
Member Author

Amusingly, that is exactly why I opened this PR. Previously, local to my machine, autovalue decided that maxReadTime (and all the others) were required parameters.

@kennknowles
Copy link
Member Author

Is there a revert or a forward fix I can LGTM?

@kennknowles
Copy link
Member Author

Here is an existing autovalue issue that is what happened here: google/auto#1338

@kennknowles kennknowles deleted the spark-flatten-coders branch January 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants