Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Protobuf build error with MapState.remove() in Dataflow Java Streaming Legacy Runner Job without Streaming Engine. #32892

Closed
2 of 17 tasks
baeminbo opened this issue Oct 22, 2024 · 0 comments · Fixed by #32893

Comments

@baeminbo
Copy link
Contributor

baeminbo commented Oct 22, 2024

What happened?

The pipeline with MapState was tested in Dataflow Java legacy runner without Streaming Engine.

The pipeline tests "clear", "put" and "remove" with a MapState. But, the job was stuck with a protobuf error thrown in WorkItemCommitRequest build when a key is removed from the MapState. The work was retried locally but hit the error indefinitely.

I believe this is because WindmillMap.persistDirect() doesn't set any value to Value.data for a removal while it's a required field in windmill.proto. It should set an empty data to delete a value state like WindmillValue.peristDirect().

7hnv6YbEZ8PHiQD
eJzXpxvVcFXuHaG

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment