Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Failing Test]: Python Coverage is failing because of new version of typing-extension release #30806

Closed
1 of 16 tasks
riteshghorse opened this issue Mar 29, 2024 · 5 comments
Closed
1 of 16 tasks

[Failing Test]: Python Coverage is failing because of new version of typing-extension release #30806

riteshghorse opened this issue Mar 29, 2024 · 5 comments
Assignees
@riteshghorse
Labels
bug failing test P2 permared python tests
Milestone
2.56.0 Release

Comments

@riteshghorse
Copy link
Contributor

What happened?

It looks like two of our python tests using tensorflow are failing. The reason being that the tensorflow has dependency on typing extension <4.6

image

and

image

Issue Failure

Failure: Test is continually failing

Issue Priority

Priority: 2 (backlog / disabled test but we think the product is healthy)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@riteshghorse riteshghorse self-assigned this Mar 29, 2024
This was referenced Mar 29, 2024
Merged
Closed
@Abacn
Copy link
Contributor

Abacn commented Apr 1, 2024

Also caused #30799

@Abacn
Copy link
Contributor

Abacn commented Apr 1, 2024

I see the pip command used includes --pre, is this expected?

@riteshghorse
Copy link
Contributor Author

Yes, I think it was added to catch issues like these, that is, to catch breaking changes from other libraries by checking against pre-releases.

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Apr 1, 2024 •
edited
Loading

Until tensorflow==2.13, it has strict dependency on typing-extensions<4.6.0 which is creating this issue. I'll move the version to 2.14 for relevant tests

@Abacn Abacn mentioned this issue Apr 1, 2024
Merged
@damccorm damccorm mentioned this issue Apr 5, 2024
Merged
@riteshghorse
Copy link
Contributor Author

#30863 fixed it

@github-actions github-actions bot added this to the 2.56.0 Release milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riteshghorse riteshghorse

Labels
bug failing test P2 permared python tests
Projects
None yet
Milestone
2.56.0 Release
Development

No branches or pull requests
2 participants
@Abacn @riteshghorse