Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Nullness and other validation checks not running on org.apache.beam.runners.dataflow.worker.windmill due to broad generatedClassPatterns #30183

Open
1 of 16 tasks
scwhittle opened this issue Feb 1, 2024 · 2 comments

Comments

@scwhittle
Copy link
Contributor

What happened?

A generatedClassPatterns was added to build.gradle

/^org\.apache\.beam\.runners\.dataflow\.worker\.windmill.*/

There are some generated AutoBuilder classes within this package but there are also lots of non-generated classes as well which could benefit from the automatic checks.

The pattern could be changed to require AutoBuilder_ string as well but requires fixing the surfaced issues at the same time.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@scwhittle
Copy link
Contributor Author

@m-trieu Can you look into fixing this?

@scwhittle
Copy link
Contributor Author

@m-trieu ping since this will cause more and more drift from correct annotations over time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant