Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Cleanup Python tests in pipeline options module #28024

Closed
1 of 15 tasks
kerrydc opened this issue Aug 16, 2023 · 2 comments
Closed
1 of 15 tasks

[Task]: Cleanup Python tests in pipeline options module #28024

kerrydc opened this issue Aug 16, 2023 · 2 comments
Assignees
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. good first issue P3 python task

Comments

@kerrydc
Copy link
Contributor

kerrydc commented Aug 16, 2023

What needs to happen?

Current Python tests in options/pipeline_options_test.py and options/pipline_options_validator_test.py use an antipattern of for loops to approximate parameterized testing. This has the side effect of failing on the first test case that fails in the loop, masking further errors. In addition, the asserts do not contain the case the triggered the failure, making it hard to see which case failed.

Rewrite these tests to use https://pypi.org/project/parameterized/. Ensure that the test failures give clear error messages, and also ensure that the tests cases are all executed even when the first one fails.

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@timgrein
Copy link
Contributor

Would like to take a look at that one! :)

@timgrein
Copy link
Contributor

.take-issue

@github-actions github-actions bot added this to the 2.51.0 Release milestone Aug 25, 2023
@damccorm damccorm added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. good first issue P3 python task
Projects
None yet
Development

No branches or pull requests

5 participants