-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Include python-snappy in Python 3.11 containers once python-snappy supports Python 3.11 #25985
Comments
.take-issue |
Are we on track for these for 2.48? @AnandInguva |
3.11 wheels are not available for this yet. We can change the milestone on this. |
no new python-snappy release yet, move onto 2.50.0 |
2.50 release manager here. Please complete work and get it into the main branch in that time, or move this issue to the 2.51 Milestone: https://github.com/apache/beam/milestone/15 |
No new releases from python-snappy to support it. Moving to 2.51.0 |
No new release, bumping it again. |
Bumping this again since there's no new release. From intake/python-snappy#124 it looks like this may not actually ever happen. @AnandInguva any reason we need this in the container or can we just close this? |
Actually snappy is installable on Python 3.11 as long as one installs snappy linux headers:
Dockerfile already includes this dep, and snappy is installable in Beam Python 3.11 docker containers. However requirement generation fails to process this manual dependency, since on most beam committers machines (and maybe on GHA workers?) libsnappy-dev is not installed. |
snappy is optional ; i think it might be used by some fastavro users if they use snappy codec, and it optimizies TFRecordIO, which falls back on less efficient implementation if snappy is not provided. Given that snappy is no longer maintained, there might be more efficient alternatives (zstd?) |
One workaround for issues like this (and also to enable macbook users), would be to generate requirements using Beam's docker container, as defined by Dockerfile, instead of a virtual environment on a committer's local machine. Although that would require having access to docker or cloudbuild. |
@tvalentyn do you anticipate finishing this task before the branch cut? |
|
What needs to happen?
What needs to happen?
Currently, the installation of
python-snappy
from sdist fails. the wheels for python 3.11 is not yet available. Beam doesn't directly depend onpython-snappy
but we would eventually want to include it in the python 3.11 container.Tracking issue to make sure Beam includes
python-snappy
in the Python 3.11 containers.python-snappy issue: intake/python-snappy#124
Issue Priority
Priority: 2 (default / most normal work should be filed as P2)
Issue Components
The text was updated successfully, but these errors were encountered: