Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44590: [C++] Add const and & to arrow::Array::statistics() return type #44592

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 31, 2024

Rationale for this change

It must be immutable.

What changes are included in this PR?

Add missing const and &.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

This PR includes breaking changes to public APIs.

Copy link

⚠️ GitHub issue #44590 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit e1fa7e5 into apache:main Oct 31, 2024
41 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 31, 2024
@kou kou deleted the cpp-array-statistics-const branch October 31, 2024 23:47
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e1fa7e5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants