Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44588: [GLib] Add GArrowDecimal64 Class #44591

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

hiroyuki-sato
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato commented Oct 31, 2024

Rationale for this change

Decimal64 class has been introeduced. It is necessary to support in GLib.

What changes are included in this PR?

Implement GArrowDecimal64 class.

Are these changes tested?

YES

Are there any user-facing changes?

NO

Copy link

⚠️ GitHub issue #44588 has been automatically assigned in GitHub to PR creator.

c_glib/test/test-decimal64.rb Outdated Show resolved Hide resolved
c_glib/arrow-glib/decimal.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 31, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 31, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 567f9c5 into apache:main Oct 31, 2024
11 checks passed
@kou kou removed the awaiting change review Awaiting change review label Oct 31, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 31, 2024
@hiroyuki-sato hiroyuki-sato deleted the topic/garrow-decimal64 branch October 31, 2024 07:42
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 567f9c5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants