Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44581: [C++] Minor: ArrayData ctor can assign null_count directly #44582

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Oct 30, 2024

Rationale for this change

See https://godbolt.org/z/37reoKTfK

The ArrayData ctor can assign null_count directly, rather than SetNullCount.

What changes are included in this PR?

Change null_count assigned directly

Are these changes tested?

Covered by existing

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #44581 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 31, 2024
@mapleFU mapleFU merged commit 3917b60 into apache:main Oct 31, 2024
39 of 40 checks passed
@mapleFU mapleFU removed the awaiting merge Awaiting merge label Oct 31, 2024
@mapleFU mapleFU deleted the minor-opt-array-data-ctor branch October 31, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants