GH-35589: [Ruby] Add support or JRuby #44346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Ruby
Component: GLib
awaiting committer review
This is not a complete support. This just can create int8 and int32 arrays by using the Java implementation not the C++ implementation. We can improve this step by step. Note that we can build gem for JRuby but we'll not release it for now. We need to build our gems as artifacts by CI in release process and publish approved gems after release vote. If we use the current "gem build && gem push" for JRuby gems, we need JRuby on release. It's not desired because it increases release complexity.
|
+1 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 34ce119. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
JRuby is a Ruby implementation. It's based on Java. We have the Java implementation. So we can use it for JRuby.
What changes are included in this PR?
This is not a complete support. This just can create int8 and int32 arrays by using the Java implementation not the C++ implementation. We can improve this step by step.
Note that we can build gem for JRuby but we'll not release it for now. We need to build our gems as artifacts by CI in release process and publish approved gems after release vote. If we use the current "gem build && gem push" for JRuby gems, we need JRuby on release. It's not desired because it increases release complexity.
Are these changes tested?
Yes but only a few tests are only passed for now.
Are there any user-facing changes?
Yes.