Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43453: [Format] Add Opaque canonical extension type #43457

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 28, 2024

Rationale for this change

Add the newly ratified extension type.

What changes are included in this PR?

The type specification only.

Are these changes tested?

N/A

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #43453 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm linked an issue Jul 28, 2024 that may be closed by this pull request
3 tasks
@lidavidm lidavidm marked this pull request as ready for review July 29, 2024 05:12
@jorisvandenbossche
Copy link
Member

For future reference, most discussion happened in #41823

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 30, 2024
@lidavidm lidavidm merged commit fd53617 into apache:main Aug 2, 2024
8 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Aug 2, 2024
@lidavidm lidavidm deleted the gh-43453 branch August 2, 2024 00:40
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fd53617.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Format] Add Opaque canonical extension type
2 participants