GH-40819: [Java] Adding Spotless to Algorithm module #41825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Java
Component: Documentation
awaiting review
|
@laurentgo I made a new PR. Would you mind giving an early review? |
laurentgo
reviewed
May 27, 2024
github-actions
bot
added
awaiting committer review
|
Thank you @laurentgo for the feedback. I will update. |
vibhatha
force-pushed
the
feat-spotless-algorithm
branch
from
415cd41
to
875e16a
Compare
|
@github-actions crossbow submit -g java |
|
Revision: 6d43ea7 Submitted crossbow builds: ursacomputing/crossbow @ actions-700d797d93
|
github-actions
bot
added
awaiting changes
vibhatha
force-pushed
the
feat-spotless-algorithm
branch
from
6d43ea7
to
4ecc5f3
Compare
github-actions
bot
added
awaiting change review
|
@github-actions crossbow submit -g java |
|
Revision: 451a350 Submitted crossbow builds: ursacomputing/crossbow @ actions-07022b7a25
|
|
@github-actions crossbow submit -g java |
|
Revision: 451a350 Submitted crossbow builds: ursacomputing/crossbow @ actions-101e5e213b
|
laurentgo
reviewed
May 30, 2024
vibhatha
force-pushed
the
feat-spotless-algorithm
branch
from
451a350
to
0ab443b
Compare
vibhatha
force-pushed
the
feat-spotless-algorithm
branch
from
1084b45
to
64dc87d
Compare
lidavidm
approved these changes
Jun 6, 2024
github-actions
bot
added
awaiting merge
Co-authored-by: David Li <[email protected]>
Co-authored-by: David Li <[email protected]>
Co-authored-by: David Li <[email protected]>
Co-authored-by: David Li <[email protected]>
Co-authored-by: David Li <[email protected]>
vibhatha
force-pushed
the
feat-spotless-algorithm
branch
from
ca8ac49
to
a70f7c5
Compare
|
@lidavidm I rebased the PR, conflicts resolved. |
lidavidm
approved these changes
Jun 10, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f086b76. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 58 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Adding code style and formatting options for Algorithm module.
What changes are included in this PR?
Code formatting spotless plugin has been added.
Are these changes tested?
Yes, but doesn't involve test cases, the plugin itself corrects.
Are there any user-facing changes?
No