MINOR: [C++] Revert change in ipc/CMakeLists.txt #41701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapleFU
approved these changes
May 17, 2024
github-actions
bot
added
awaiting committer review
|
Thanks for the quick look @mapleFU. |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit dc973c2. There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
### Rationale for this change apache#40392 introduced a mistake in the the associated CMakeLists.txt, noticed by @ kou in apache#40392 (comment). ### What changes are included in this PR? A reversion of that change. ### Are these changes tested? No. ### Are there any user-facing changes? No. Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#40392 introduced a mistake in the the associated CMakeLists.txt, noticed by @kou in #40392 (comment).
What changes are included in this PR?
A reversion of that change.
Are these changes tested?
No.
Are there any user-facing changes?
No.