-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41630: [Benchmarking] Fix out-of-source build in benchmarks #41631
Conversation
@ursabot please benchmark |
Benchmark runs are scheduled for commit c7c527c. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
This comment was marked as outdated.
This comment was marked as outdated.
Benchmark runs are scheduled for commit d5a83de. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@ursabot please benchmark |
Benchmark runs are scheduled for commit 0446006. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 7 benchmarking runs that have been run so far on PR commit 0446006. There were 8 benchmark results indicating a performance regression:
The full Conbench report has more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit c555488. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
…pache#41631) ### Rationale for this change Broken benchmarks after apache#41455 ### What changes are included in this PR? Use /tmp/arrow as build dir. ### Are these changes tested? ### Are there any user-facing changes? * GitHub Issue: apache#41630 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…pache#41631) ### Rationale for this change Broken benchmarks after apache#41455 ### What changes are included in this PR? Use /tmp/arrow as build dir. ### Are these changes tested? ### Are there any user-facing changes? * GitHub Issue: apache#41630 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Rationale for this change
Broken benchmarks after #41455
What changes are included in this PR?
Use /tmp/arrow as build dir.
Are these changes tested?
Are there any user-facing changes?