Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41630: [Benchmarking] Fix out-of-source build in benchmarks #41631

Merged
merged 4 commits into from
May 14, 2024

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented May 13, 2024

Rationale for this change

Broken benchmarks after #41455

What changes are included in this PR?

Use /tmp/arrow as build dir.

Are these changes tested?

Are there any user-facing changes?

@assignUser
Copy link
Member Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented May 13, 2024

Benchmark runs are scheduled for commit c7c527c. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

Copy link

⚠️ GitHub issue #41630 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label May 13, 2024
@assignUser

This comment was marked as outdated.

@ursabot
Copy link

ursabot commented May 13, 2024

Benchmark runs are scheduled for commit d5a83de. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

This comment was marked as outdated.

This comment was marked as outdated.

@assignUser
Copy link
Member Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented May 13, 2024

Benchmark runs are scheduled for commit 0446006. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

Copy link

Thanks for your patience. Conbench analyzed the 7 benchmarking runs that have been run so far on PR commit 0446006.

There were 8 benchmark results indicating a performance regression:

The full Conbench report has more details.

@assignUser assignUser marked this pull request as ready for review May 13, 2024 12:36
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 13, 2024
@assignUser assignUser merged commit c555488 into apache:main May 14, 2024
7 of 8 checks passed
@assignUser assignUser removed the awaiting merge Awaiting merge label May 14, 2024
@assignUser assignUser deleted the fix-benchmarks branch May 14, 2024 00:15
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit c555488.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…pache#41631)

### Rationale for this change

Broken benchmarks after apache#41455 
### What changes are included in this PR?

Use /tmp/arrow as build dir.

### Are these changes tested?

### Are there any user-facing changes?

* GitHub Issue: apache#41630

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request May 29, 2024
…pache#41631)

### Rationale for this change

Broken benchmarks after apache#41455 
### What changes are included in this PR?

Use /tmp/arrow as build dir.

### Are these changes tested?

### Are there any user-facing changes?

* GitHub Issue: apache#41630

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants