GH-41531: [MATLAB][Packaging] Bump matlab-actions/setup-matlab and matlab-actions/run-command from v1 to v2 in the crossbow job
#41532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atlab@v2 2. Replace matlab-actions/run-command@v1 with matlab-actions/run-command@v2
|
@github-actions crossbow submit matlab |
|
Revision: 8099250 Submitted crossbow builds: ursacomputing/crossbow @ actions-04e9a1c267
|
github-actions
bot
added
awaiting merge
|
+1 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e7f5f81. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…` and `matlab-actions/run-command` from `v1` to `v2` in the `crossbow` job (apache#41532) ### Rationale for this change I noticed `dev/tasks/matlab/github.yml` is still using `matlab-actions/setup-matlab@ v1`, which is no longer supported. See this [log](https://github.com/ursacomputing/crossbow/actions/runs/8928507510/job/24524230971#step:4:11) file. We should use `matlab-actions/setup-matlab@ v2` instead. We should also use `matlab-actions/run-command@ v2` instead of `matlab-actions/run-command@ v1`. ### What changes are included in this PR? 1. Replaced `matlab-actions/setup-matlab@ v1` with `matlab-actions/setup-matlab@ v2` in `dev/tasks/matlab/github.yml` 2. Replaced `matlab-actions/run-command@ v1` with `matlab-actions/run-command@ v2` in `dev/tasks/matlab/github.yml` ### Are these changes tested? N/A (I will trigger a crossbow job to verify the packaging workflow works as expected still). ### Are there any user-facing changes? No. * GitHub Issue: apache#41531 Authored-by: Sarah Gilmore <[email protected]> Signed-off-by: Sarah Gilmore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I noticed
dev/tasks/matlab/github.ymlis still usingmatlab-actions/setup-matlab@v1, which is no longer supported. See this log file. We should usematlab-actions/setup-matlab@v2instead. We should also usematlab-actions/run-command@v2instead ofmatlab-actions/run-command@v1.What changes are included in this PR?
Replaced
matlab-actions/setup-matlab@v1withmatlab-actions/setup-matlab@v2indev/tasks/matlab/github.ymlReplaced
matlab-actions/run-command@v1withmatlab-actions/run-command@v2indev/tasks/matlab/github.ymlAre these changes tested?
N/A (I will trigger a crossbow job to verify the packaging workflow works as expected still).
Are there any user-facing changes?
No.
matlab-actions/setup-matlabandmatlab-actions/run-commandfromv1tov2in thecrossbowjob #41531