Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][JS] Missing build directory #41920

Closed
kou opened this issue Jun 1, 2024 · 1 comment
Closed

[CI][JS] Missing build directory #41920

kou opened this issue Jun 1, 2024 · 1 comment

Comments

@kou
Copy link
Member

kou commented Jun 1, 2024

Describe the bug, including details regarding any error messages, version, and platform.

GH-41455 added build directory argument to ci/scripts/js_{build,test}.sh but it didn't change .github/workflows/js.yml that is also use ci/scripts/js_{build,test}.sh.

So JS CI jobs are failing:

AMD64 macOS 11 NodeJS 18

Run ci/scripts/js_build.sh $(pwd)
  ci/scripts/js_build.sh $(pwd)
  shell: /bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    ARCHERY_DEBUG: 1
    ARCHERY_USE_DOCKER_CLI: 1
+ arrow_dir=/Users/runner/work/arrow/arrow
+ source_dir=/Users/runner/work/arrow/arrow/js
+ build_dir=
+ : OFF
+ rm -rf /js
+ mkdir -p
usage: mkdir [-pv] [-m mode] directory_name ...
Error: Process completed with exit code 64.

AMD64 Windows NodeJS 18

Run ci/scripts/js_build.sh $(pwd)
+ arrow_dir=/d/a/arrow/arrow
+ source_dir=/d/a/arrow/arrow/js
+ build_dir=
+ : OFF
+ rm -rf /js
+ mkdir -p
mkdir: missing operand
Try 'mkdir --help' for more information.
Error: Process completed with exit code 1.

Component(s)

Continuous Integration, JavaScript

@kou kou added the Type: bug label Jun 1, 2024
kou added a commit to kou/arrow that referenced this issue Jun 1, 2024
kou added a commit that referenced this issue Jun 1, 2024
### Rationale for this change

This is a follow-up of GH-41455.

### What changes are included in this PR?

Add missing build directory argument.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41920

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 17.0.0 milestone Jun 1, 2024
@kou
Copy link
Member Author

kou commented Jun 1, 2024

Issue resolved by pull request 41921
#41921

@kou kou closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant