-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs][CI] Enable more sphinx-lint rules for documentation #41611
Comments
The current docs violates just six of the 22 sphinx-lint rules. Of these, most are useful and catch real issues. For each, I've noted which I think we should and shouldn't enable:
I think we could get away with just disabling |
Thank you for working on this @amoeba and adding a thorough summary. Agree with what is added till now 👍 |
Thanks @AlenkaF. I marked the PR as ready for review and I tagged you for review in addition to @jorisvandenbossche since he saw the last PR. |
…41612) ### Rationale for this change #41611 ### What changes are included in this PR? - Update to pre-commit config to enable all checks except `dangling-hyphen`, `line-too-long` by default - Associated fix docs ### Are these changes tested? Yes, by building and looking at the docs locally. ### Are there any user-facing changes? Just docs. * GitHub Issue: #41611 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: AlenkaF <[email protected]>
Issue resolved by pull request 41612 |
…ation (apache#41612) ### Rationale for this change apache#41611 ### What changes are included in this PR? - Update to pre-commit config to enable all checks except `dangling-hyphen`, `line-too-long` by default - Associated fix docs ### Are these changes tested? Yes, by building and looking at the docs locally. ### Are there any user-facing changes? Just docs. * GitHub Issue: apache#41611 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: AlenkaF <[email protected]>
Describe the enhancement requested
The work in #39990 enabled sphinx-lint as a pre-commit hook but enabled just two rules so as to start off simple:
sphinx-lint offers a total of 22 rules and some of these are clearly useful as, at least at the time of writing, they catch meaningful meaningful problems in our documentation sources.
We should consider the full ruleset and enabling as many as we think offer good value.
Component(s)
Continuous Integration, Documentation
The text was updated successfully, but these errors were encountered: