Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][Integration] csharp integration tests are failing on main #41258

Closed
paleolimbot opened this issue Apr 17, 2024 · 1 comment
Closed

[C#][Integration] csharp integration tests are failing on main #41258

paleolimbot opened this issue Apr 17, 2024 · 1 comment

Comments

@paleolimbot
Copy link
Member

paleolimbot commented Apr 17, 2024

Describe the bug, including details regarding any error messages, version, and platform.

It looks like #40873 caused integration tests to start failing! This was my oversight when attempting to fix a bug 😬 .

edit: The first PR I identified was unrelated...the last C# change after a successful run was #41230 .

Last successful run: https://github.com/apache/arrow/actions/runs/8702906942/job/23867989195

First failure: https://github.com/apache/arrow/actions/runs/8711646255/job/23896211289

Component(s)

C#, Integration

paleolimbot added a commit that referenced this issue Apr 17, 2024
… with non-zero offsets (#41259)

### Rationale for this change

After #41230 , the integration tests are failing on main .

### What changes are included in this PR?

The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.

### Are these changes tested?

Via the integration test CI job.

### Are there any user-facing changes?

No
* GitHub Issue: #41258

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@paleolimbot paleolimbot added this to the 17.0.0 milestone Apr 17, 2024
@paleolimbot
Copy link
Member Author

Issue resolved by pull request 41259
#41259

tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…uffers with non-zero offsets (apache#41259)

### Rationale for this change

After apache#41230 , the integration tests are failing on main .

### What changes are included in this PR?

The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.

### Are these changes tested?

Via the integration test CI job.

### Are there any user-facing changes?

No
* GitHub Issue: apache#41258

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
…uffers with non-zero offsets (apache#41259)

### Rationale for this change

After apache#41230 , the integration tests are failing on main .

### What changes are included in this PR?

The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.

### Are these changes tested?

Via the integration test CI job.

### Are there any user-facing changes?

No
* GitHub Issue: apache#41258

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…uffers with non-zero offsets (apache#41259)

### Rationale for this change

After apache#41230 , the integration tests are failing on main .

### What changes are included in this PR?

The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.

### Are these changes tested?

Via the integration test CI job.

### Are there any user-facing changes?

No
* GitHub Issue: apache#41258

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…uffers with non-zero offsets (apache#41259)

### Rationale for this change

After apache#41230 , the integration tests are failing on main .

### What changes are included in this PR?

The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.

### Are these changes tested?

Via the integration test CI job.

### Are there any user-facing changes?

No
* GitHub Issue: apache#41258

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…uffers with non-zero offsets (apache#41259)

### Rationale for this change

After apache#41230 , the integration tests are failing on main .

### What changes are included in this PR?

The bit-by-bit comparison branch in the validity bitmap comparison is missing an offset on one side of the comparison. This PR adds that offset back in.

### Are these changes tested?

Via the integration test CI job.

### Are there any user-facing changes?

No
* GitHub Issue: apache#41258

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant