Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sni and skipverify option for etcd tls #2850

Closed
wants to merge 2 commits into from

Conversation

druggo
Copy link

@druggo druggo commented Aug 8, 2023

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

add two option for etcd tls connection:

  • sni: the servername of the etcd server certificate
  • skipverify: skip etcd server certificate verify

Related issues

resolve #2808 #2815

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #2850 (3ddb44f) into master (e8bc9b9) will decrease coverage by 14.55%.
The diff coverage is n/a.

❗ Current head 3ddb44f differs from pull request most recent head 5545843. Consider uploading reports for the commit 5545843 to get more accurate results

@@             Coverage Diff             @@
##           master    #2850       +/-   ##
===========================================
- Coverage   70.55%   56.01%   -14.55%     
===========================================
  Files         201      183       -18     
  Lines        7846     7102      -744     
  Branches      881      877        -4     
===========================================
- Hits         5536     3978     -1558     
- Misses       2001     2914      +913     
+ Partials      309      210       -99     
Flag Coverage Δ
backend-e2e-test-ginkgo ?
backend-unit-test 49.95% <ø> (ø)
frontend-e2e-test 61.69% <ø> (-7.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
api/internal/conf/conf.go 66.22% <ø> (ø)

... and 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@druggo druggo changed the title feat: support sni and verify flag for etcd tls feat: support sni and skipverify option for etcd tls Aug 12, 2023
@druggo druggo closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add option to skip strict verification on ETCD's certification.
2 participants