Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable route export openapi func #2801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

monkeyDluffy6017
Copy link

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The export openapi func doesn't work well, we need to disable it for now

Related issues

fix/resolve #1

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #2801 (5b607b2) into master (764a04e) will increase coverage by 5.39%.
The diff coverage is n/a.

❗ Current head 5b607b2 differs from pull request most recent head f2d1820. Consider uploading reports for the commit f2d1820 to get more accurate results

@@            Coverage Diff             @@
##           master    #2801      +/-   ##
==========================================
+ Coverage   68.87%   74.26%   +5.39%     
==========================================
  Files         139      200      +61     
  Lines        3746     7551    +3805     
  Branches      880      880              
==========================================
+ Hits         2580     5608    +3028     
- Misses       1166     1660     +494     
- Partials        0      283     +283     
Flag Coverage Δ
backend-e2e-test-ginkgo 63.75% <ø> (?)
backend-unit-test 48.01% <ø> (?)
frontend-e2e-test 77.33% <ø> (+8.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/route.go 88.09% <ø> (ø)

... and 79 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

web/yarn.lock Outdated Show resolved Hide resolved
@bzp2010
Copy link
Contributor

bzp2010 commented May 11, 2023

@monkeyDluffy6017 Maybe just comment it rather than delete them?

@monkeyDluffy6017
Copy link
Author

@monkeyDluffy6017 Maybe just comment it rather than delete them?

We don't know when this functionality will be added back, and it's not aesthetically pleasing to have so much code commented out in the project

@0xdeadbeer
Copy link

What changes will this PR take into?
The export openapi func doesn't work well, we need to disable it for now

May I ask what you're referring to with "doesn't work well"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants