fix: locked input to a min of "0" for Retries #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neilblaze
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2777 +/- ##
==========================================
- Coverage 74.02% 68.60% -5.43%
==========================================
Files 201 139 -62
Lines 7874 3774 -4100
Branches 886 886
==========================================
- Hits 5829 2589 -3240
+ Misses 1738 1185 -553
+ Partials 307 0 -307
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 82 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Baoyuantop
reviewed
Mar 20, 2023
|
@Baoyuantop Will this work or should I have to refactor it a little bit? it('should not allow negative values for retries', () => {
cy.visit('/routes/list');
cy.get('[name="Retries"]').type('-1').blur();
cy.contains('Retry times should not be less than 0');
}); |
|
You can just commit your code directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
In the Apisix dashboard, in the inputfield of
Retriesunder Services, we cannot set a negative value as of currently it doesn't supports it. Hence the up/down arrows have no function if the value is in the negative range.RE: Primarily we can apply a
visibility: hiddenfor.ant-input-number-handler-wrap, but I think the better way is to not remove thoseup/downarrows and instead, we can lock the input to a minimum value of 0.Related issues
resolves #2775
Checklist:
cc: @Baoyuantop, @freemankevin