Fix pyhive hive_pure_sasl extra name #37323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it was added with correct name by #32607 |
|
Not really. That was deliberate and it is there to follow https://peps.python.org/pep-0685/ . Any (conforming) package installer should normalize the extras when comparing them to I believed there is (wrong) warning that the extra does not exist when it is used, but the extra is actually used (or so I thought). But I just checked it and indeed it seems that PEP-0685 for that case is not yet implemented by |
potiuk
approved these changes
Feb 11, 2024
dirrao
approved these changes
Feb 11, 2024
eladkal
approved these changes
Feb 11, 2024
|
Yeah, this is simply manifestation of unfinished pypa/pip#11445 |
81 tasks
potiuk
added
changelog:skip
potiuk
pushed a commit
that referenced
this pull request
Feb 13, 2024
(cherry picked from commit 9a10085)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 9a10085)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this warning in the build ci image job:
After checking, found that the correct name of this extra was always
hive_pure_sasl: dropbox/PyHive#454