-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hardcode the numbers of sync nodes #75
Comments
this will be too complicated: as it will also require simultaneous templating of docker-compose.yml files, .env, and the generator, along with post-processing configurations. |
I think it is already too complicated. There are too many shell scripts and Python scripts, and hardcoding makes customization difficult. Furthermore, are three nodes by default necessary for self-hosted and all-in-one users? Are there any design reasons for this? Meanwhile, any-sync-dockercompose/docker-generateconfig/setListenIp.py Lines 57 to 61 in 82b9ec1
|
The minimum number of any-sync-nodes required for the cluster to operate is 3. |
Have you read a contributing guide?
Clear and concise description of the problem
any-sync-dockercompose/.env.common
Lines 22 to 38 in 9609edf
any-sync-dockercompose/docker-generateconfig/anyconf.sh
Lines 33 to 35 in 9609edf
any-sync-dockercompose/docker-generateconfig/anyconf.sh
Lines 39 to 41 in 9609edf
any-sync-dockercompose/docker-generateconfig/anyconf.sh
Lines 55 to 56 in 9609edf
any-sync-dockercompose/docker-generateconfig/processing.sh
Line 29 in 9609edf
any-sync-dockercompose/docker-generateconfig/processing.sh
Lines 39 to 46 in 9609edf
Suggested solution
I'm not sure, maybe jinja2 is a good choice?
Alternative
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: