Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove wrapping quotes #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not remove wrapping quotes #16

wants to merge 1 commit into from

Conversation

xoliver
Copy link

@xoliver xoliver commented Mar 15, 2018

Hi @anton-dev-ua , thank you for this plugin, it's making my life so much easier!

I ran into the issue where running the plugin successive times effectively changes the content of cells, and that has caused me trouble running it multiple times (""a value"" becomes "a value" and then becomes a value). I think a formatting plugin should not alter the values if it can, as registered by somebody else in #11

Here's a proposal for this, I figured I might as well contribute it back so everybody can benefit. I haven't touched the xml file on purpose since I'd like to see if you have reasons for it to behave the current way 😄

Thanks!

@aanutter
Copy link

Is this scheduled for release anytime soon?

@xoliver
Copy link
Author

xoliver commented Jul 18, 2019

Never heard back so I'd guess no?

@aanutter
Copy link

@anton-dev-ua If you are still supporting this tool, would be great to get this fixed. It's a subtle bug, so it's easy to overlook on PR's. Especially if you use scenario outline, with large examples tables.

@idrisahmed251
Copy link

Hi folks, I helped write the original version with Anton but have lost contact with him several years ago. Generally happy with the suggestions, but do you have any advice for how to apply them to the tool?

@aanutter
Copy link

Hi @idrisahmed251 ,
I believe this PR opened by @xoliver would address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants