std::result_of deprecation
#30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [here](https://en.cppreference.com/w/cpp/types/result_of#Notes) for reasons why `std::invoke_result_t` is to be used over `std::result_of<>::type`. Code also amended functionally to make the template variadic (whitespace and naming amendments preferential and optional). At the very least, lines 3 and 6 need to be amended to include `typename` in order to compile. .:. Line 3 .:. std::future<std::result_of<F(A&&)>::type> std::future<typename std::result_of<F(A&&)>::type> .:. Line 6 .:. typedef std::result_of<F(A&&)>::type result_type; typedef typename std::result_of<F(A&&)>::type result_type;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion
See here for reasons why
std::invoke_result_tis to be used overstd::result_of<>::type.Code also amended functionally to make the template variadic (whitespace and naming amendments preferential and optional).
At the very least, lines 3 and 6 need to be amended to include
typenamein order to compile.Line 3
std::future<std::result_of<F(A&&)>::type> std::future<typename std::result_of<F(A&&)>::type>Line 6
Tested in Xcode 14.3