From 3437e45d055e5902892c19261aa47fb60808c5ca Mon Sep 17 00:00:00 2001 From: Jeremy Yoder <45078974+jyoder-deloitte@users.noreply.github.com> Date: Tue, 7 Jul 2020 07:22:21 -0400 Subject: [PATCH] Set correct default directory for tests (#2732) --- molecule/test/unit/verifier/test_ansible.py | 4 ++-- molecule/verifier/base.py | 2 +- molecule/verifier/testinfra.py | 7 ------- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/molecule/test/unit/verifier/test_ansible.py b/molecule/test/unit/verifier/test_ansible.py index 68448bb4a..04c700908 100644 --- a/molecule/test/unit/verifier/test_ansible.py +++ b/molecule/test/unit/verifier/test_ansible.py @@ -57,8 +57,8 @@ def test_enabled_property(_instance): def test_directory_property(_instance): parts = _instance.directory.split(os.path.sep) - # default verifier is ansible, which keeps tests in molecule folder. - assert "molecule" == parts[-1] + # Unused by Ansible verifier + assert ["molecule", "default", "tests"] == parts[-3:] @pytest.mark.parametrize("config_instance", ["_verifier_section_data"], indirect=True) diff --git a/molecule/verifier/base.py b/molecule/verifier/base.py index 29e90bc1a..63c78f834 100644 --- a/molecule/verifier/base.py +++ b/molecule/verifier/base.py @@ -94,7 +94,7 @@ def enabled(self): def directory(self): return os.path.join( self._config.scenario.directory, - self._config.config["verifier"].get("directory", "molecule"), + self._config.config["verifier"].get("directory", "tests"), ) @property diff --git a/molecule/verifier/testinfra.py b/molecule/verifier/testinfra.py index a6343b2c6..214bd9931 100644 --- a/molecule/verifier/testinfra.py +++ b/molecule/verifier/testinfra.py @@ -119,13 +119,6 @@ def default_options(self): return d - @property - def directory(self): - return os.path.join( - self._config.scenario.directory, - self._config.config["verifier"].get("directory", "tests"), - ) - # NOTE(retr0h): Override the base classes' options() to handle # ``ansible-galaxy`` one-off. @property