Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[Associated vote ended on 2023-07-18] Unmaintained collection: netapp.azure #234

Closed
mariolenz opened this issue Jun 3, 2023 · 13 comments
Closed

Comments

@mariolenz
Copy link
Contributor

mariolenz commented Jun 3, 2023

Summary

The netapp.azure collection looks unmaintained / abandoned, it has:

Additionally, when I run ansible-test sanity it seems to fail with the following errors:

ERROR: Found 1 pylint issue(s) which need to be resolved:
ERROR: tests/unit/compat/builtins.py:29:4: unused-import: Unused import __builtin__

and

ERROR: Found 16 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/azure_rm_netapp_account.py:0:0: parameter-type-not-in-doc: Argument 'thumbprint' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_account.py:0:0: parameter-type-not-in-doc: Argument 'x509_certificate_path' in argument_spec defines type as 'path' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_account.py:0:0: undocumented-parameter: Argument 'thumbprint' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_account.py:0:0: undocumented-parameter: Argument 'x509_certificate_path' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_capacity_pool.py:0:0: parameter-type-not-in-doc: Argument 'thumbprint' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_capacity_pool.py:0:0: parameter-type-not-in-doc: Argument 'x509_certificate_path' in argument_spec defines type as 'path' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_capacity_pool.py:0:0: undocumented-parameter: Argument 'thumbprint' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_capacity_pool.py:0:0: undocumented-parameter: Argument 'x509_certificate_path' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_snapshot.py:0:0: parameter-type-not-in-doc: Argument 'thumbprint' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_snapshot.py:0:0: parameter-type-not-in-doc: Argument 'x509_certificate_path' in argument_spec defines type as 'path' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_snapshot.py:0:0: undocumented-parameter: Argument 'thumbprint' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_snapshot.py:0:0: undocumented-parameter: Argument 'x509_certificate_path' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_volume.py:0:0: parameter-type-not-in-doc: Argument 'thumbprint' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_volume.py:0:0: parameter-type-not-in-doc: Argument 'x509_certificate_path' in argument_spec defines type as 'path' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_netapp_volume.py:0:0: undocumented-parameter: Argument 'thumbprint' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_netapp_volume.py:0:0: undocumented-parameter: Argument 'x509_certificate_path' is listed in the argument_spec, but not documented in the module documentation
@mariolenz
Copy link
Contributor Author

mariolenz commented Jun 18, 2023

The Bullhorn issue #104 2023-06-03

@mariolenz
Copy link
Contributor Author

Vote happens in #249

@mariolenz mariolenz changed the title Unmaintained collection: netapp.azure [Vote ends on 2023-07-18] Unmaintained collection: netapp.azure Jul 4, 2023
@mariolenz
Copy link
Contributor Author

@ansible-community/steering-committee Please vote on #249 if you haven't done yet. It's the last day and there are still not enough votes from the steering committee.

@gotmax23
Copy link
Contributor

I see +8/0/0 (@mariolenz, @felixfontein, @russoz, @briantist, me, @Andersson007, @gundalow, @acozine) from the SC and +1/0/0 from the community (@cybette). Can another @ansible-community/steering-committee member please confirm?

@mariolenz mariolenz changed the title [Vote ends on 2023-07-18] Unmaintained collection: netapp.azure [Vote ended on 2023-07-18] Unmaintained collection: netapp.azure Jul 18, 2023
@mariolenz
Copy link
Contributor Author

I counted the same, 8 +1 from the SC and 1 +1 from the community. No one seems to be against it (no -1 at all).

So the vote has been accepted and I will prepare an announcement for The Bullhorn and a PR to deprecate the collection.

Thanks all!

@mariolenz
Copy link
Contributor Author

@felixfontein felixfontein changed the title [Vote ended on 2023-07-18] Unmaintained collection: netapp.azure [Associated vote ended on 2023-07-18] Unmaintained collection: netapp.azure Aug 16, 2023
@felixfontein
Copy link
Contributor

This collection had a new release in September, but that release wasn't tagged (ansible-community/ansible-build-data#223 (comment)). There has been no reaction so far in the corresponding issue in the repository either (ansible-collections/netapp.azure#8).

@carchi8py
Copy link

Sorry i missed the first ping fixed the release in github

@carchi8py
Copy link

@felixfontein can we update the user for Netapp. @lonico is no longer at Netapp and should be removed. And i was on vacation most of Oct so just getting to see these now. Can we add my counter parts in case I'm out again for a month and they can respond.
@suhasbshekar
@wenjun666
@chuyich

@felixfontein
Copy link
Contributor

@carchi8py for which of the netapp collections should they be added?

@carchi8py
Copy link

netapp.aws
netapp.um_info
netapp.cloudmanager
netapp.azure
netapp.ontap

@felixfontein
Copy link
Contributor

felixfontein commented Nov 6, 2023

I created ansible-community/ansible-build-data#313 to update the maintainers list for these collections.

@mariolenz
Copy link
Contributor Author

IIRC we've kept issues like this one about collection removal from version X open until X has been released. However, since we've moved discussions to the forum and the collection has been removed from 10.0.0.a1, I think we should close this even if 10.0.0 hasn't been released yet.

If someone wants to discuss cancelling the removal / re-adding of the collection, please open a topic in the forum.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants