Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the examples don't have FQCN from the Ansible-maintained collections #81

Open
samccann opened this issue Jun 5, 2020 · 8 comments
Labels
documentation Improvements or additions to documentation

Comments

@samccann
Copy link
Contributor

samccann commented Jun 5, 2020

I believe this is boilerplate text added via the docs pipeline:
These examples assume the collections keyword is defined in playbook and do not use the fully qualified collection name.

The Ansible content team has decided to update all their examples to use FQCN before their 1.0.0 release. So we'll need a way to NOT put that boilerplate in the following collections:

https://github.com/ansible-collections/amazon.aws
https://github.com/ansible-collections/ansible.netcommon
https://github.com/ansible-collections/ansible.posix
https://github.com/ansible-collections/ansible.windows
https://github.com/ansible-collections/arista.eos
https://github.com/ansible-collections/cisco.asa
https://github.com/ansible-collections/cisco.ios
https://github.com/ansible-collections/cisco.iosxr
https://github.com/ansible-collections/cisco.nxos
https://github.com/ansible-collections/community.aws
https://github.com/ansible-collections/kubernetes
https://github.com/ansible-collections/community.network
https://github.com/ansible-collections/vmware
https://github.com/ansible-collections/vmware_rest
https://github.com/ansible-collections/frr.frr
https://github.com/ansible-collections/ibm.qradar
https://github.com/ansible-collections/junipernetworks.junos
https://github.com/ansible-collections/openvswitch.openvswitch
https://github.com/ansible-collections/splunk.es
https://github.com/ansible-collections/symantec.epm
https://github.com/ansible-collections/vyos.vyos

@samccann
Copy link
Contributor Author

samccann commented Jun 5, 2020

ON HOLD - Ansible team is evaluating that list above to see if all will be done in time.

@jborean93
Copy link

jborean93 commented Jun 5, 2020

Just an FYI the ansible.windows has updated its examples to the FQCN version with ansible-collections/ansible.windows@947da18.

@abadger
Copy link
Contributor

abadger commented Jun 7, 2020

  • Do we think this is auto-detectable or does it need to be manually selectable?
  • If manually selected, does it make more sense to be a per-collection setting or a per-plugin setting?

@gundalow
Copy link
Contributor

gundalow commented Jun 7, 2020

Which boiler plate is being referred to?

@gundalow
Copy link
Contributor

gundalow commented Jun 7, 2020

https://toshio.fedorapeople.org/ansible/docsite/collections/ansible/netcommon/net_linkagg_module.html#examples

@samccann Thanks. So this is the EXAMPLE block in every module, I don't believe we could update this via docs build. We'd need to update every module like ansible-collections/ansible.windows@947da18

See also ansible-collections/overview#40 which has some other details, as well as a link to a script which can help doing the bulk Short -> FQCN update.

@samccann
Copy link
Contributor Author

samccann commented Jun 9, 2020

@gundalow the issue is some teams have already updated to use FQCN on their collections. So we can't have this boilerplate list on all collections.
@abadger I don't know of a way to detect this programmatically, so I was thinking we'd need a manual list of collections to apply the boilerplate text to. The Collection owners I work with are making this change per collection (either the entire collection uses FQCN or none do). I sure hope teams aren't making the change per plugin but I don't know for sure.

@abadger
Copy link
Contributor

abadger commented Jun 17, 2020

When we're ready for this, I think we can implement it by adding a file to the ansible-build-data repo that lists which collections do and do not need to have the boilerplate.

Alternatives:

  • Same file but have it per-plugin. Probably a little more complex to code and the file will be bigger.
  • Put this information into the collection. I don't think galaxy will show any extra information... We may have to parse runtime,yml for information soon so it could go in there. But runtime.yml might not be easily extendable (need code and schema changes in ansible-base in order to do so). Another ad hoc file is probably something the collection designers want to avoid.

@acozine acozine added the documentation Improvements or additions to documentation label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants