Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violation of semantic versioning #463

Closed
Tracked by #223
felixfontein opened this issue May 20, 2023 · 4 comments
Closed
Tracked by #223

Violation of semantic versioning #463

felixfontein opened this issue May 20, 2023 · 4 comments
Assignees
Labels
bug This issue/PR relates to a bug. has_pr verified This issue has been verified/reproduced by maintainer

Comments

@felixfontein
Copy link
Contributor

SUMMARY

The collection is violating one of the basic Ansible inclusion criteria: semantic versioning.

The bugfix release 1.5.1contained multiple new features and modules: https://github.com/ansible-collections/ansible.posix/blob/main/CHANGELOG.rst#id3

The bugfix release 1.5.2 contained new plugins and options as well: https://github.com/ansible-collections/ansible.posix/blob/main/CHANGELOG.rst#id1

The bugfix release 1.5.4 also contains multiple new features: https://github.com/ansible-collections/ansible.posix/blob/main/CHANGELOG.rst#minor-changes

Please make sure to use semantic versioning for all new releases (https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_requirements.html#versioning-and-deprecation)!

ISSUE TYPE
  • Bug Report
COMPONENT NAME

collection

@felixfontein
Copy link
Contributor Author

There has been another, way more serious semantic versioning violation: ansible.posix 1.6.0 removes a plugin. Removal of content is only allowed in major releases!

Please revert that change and do a new release (1.6.1) as soon as possible. Thanks. As long as this does not happen, Ansible 9 and 10 will not accept new versions of ansible.posix, and will stick to versions < 1.6.0.

You can re-do the removal once you actually do a new major release.

@saito-hideki
Copy link
Collaborator

saito-hideki commented Oct 8, 2024

@felixfontein Thanks for the information.
The current main branch includes several minor changes. Therefore, I am planning to release version 1.7.0, which rolls back to include skippy plugin and reflect minor-changes following the guidelines. After that, version 1.6.0 will be discontinued.
After that, I plan to release 2.0.0, which will remove skippy.

If there are no issues with my plan, I will proceed with the release within the next few days. Please share your thoughts with me.

Continue the discussion here #149 (comment)

@saito-hideki saito-hideki self-assigned this Oct 10, 2024
@saito-hideki saito-hideki added bug This issue/PR relates to a bug. verified This issue has been verified/reproduced by maintainer has_pr labels Oct 10, 2024
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 10, 2024
Create a stable branch for ansible.posix version 1.x as stable-1

SUMMARY
We are creating a stable branch to improve maintainability and ensure more accurate releases in preparation for the version 2.x release.
The new features(A.K.A minor-changes and major-changes) will be reflected in main branch only, but bug fixes can be backported to the stable branch.

Fixes #463
Fixes #573

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ansible.posix
ADDITIONAL INFORMATION



None

Reviewed-by: Andrew Klychkov <[email protected]>
Reviewed-by: Adam Miller <[email protected]>
Reviewed-by: Felix Fontein <[email protected]>
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 11, 2024
Release 1.6.1 commit

SUMMARY
Release 1.6.1 commit

#149
#463

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible.posix

ADDITIONAL INFORMATION
None
@saito-hideki
Copy link
Collaborator

@felixfontein I have released 1.6.1 #574
I will monitor this release in a few days, And then, if there are no problems, I will close this issue.

@felixfontein
Copy link
Contributor Author

Closing since this has been resolved from our point of view. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. has_pr verified This issue has been verified/reproduced by maintainer
Projects
None yet
Development

No branches or pull requests

2 participants