Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when execute ibc-transfer and check balance #273

Open
aquariusluo opened this issue Feb 14, 2024 · 0 comments
Open

Crash when execute ibc-transfer and check balance #273

aquariusluo opened this issue Feb 14, 2024 · 0 comments

Comments

@aquariusluo
Copy link
Contributor

Title:
Finding Security Vulnerabilities

Summery:
A crash is raised when execute ibc-transfer which rpc is with "http://" or check balance via namadac --node with "http://".

Details:

  1. Install namada v0.31.4 CLI without node running.
  2. Generate IBC relayer for namada SE and osmosis
  3. ibc-transfer from SE to osmosis with rpc 'http://94.130.90.47:26657' which's result in crash
  4. ibc-transfer from SE to osmosis with rpc '94.130.90.47:26657' which's good.
  5. Check SE balance with rpc 'http://94.130.90.47:26657' which's result in crash

Process:
IBC Channel:

  • id: "shielded-expedition.88f17d1d14", ChannelId: "channel-42", connection_id: "connection-64"
  • id: "osmo-test-5",ChannelId: "channel-5557", connection_id: "connection-1922"

namada --version
Namada v0.31.4

namadaw find --alias se_wallet
Found transparent keys:
Alias "se_wallet" (encrypted):
Public key hash: EBA13A31D3EFA00AD18C5899518D8C619DB1B4F9
Public key: tpknam1qrcr98xtauxv292mqzuyz6nkll8vpm0xvtjcdkpq9lp94pujcqktyxka4uk
Found transparent address:
"se_wallet": Implicit: tnam1qr46zw3360h6qzk333vfj5vd33semvd5ly8cyl00

  • Crash when rpc with "http://" -
    namadac --chain-id shielded-expedition.88f17d1d14 --base-dir /home/namadexer/.local/share/namada balance --node http://94.130.90.47:26657 --owner se_wallet
    The application panicked (crashed).
    Message: called Result::unwrap() on an Err value: "Invalid Tendermint address: \n 0: \u{1b}[91merror parsing data: invalid address scheme: "http://94.130.90.47:26657"\u{1b}[0m\n\nLocation:\n \u{1b}[35m/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/flex-error-0.4.4/src/tracer_impl/eyre.rs\u{1b}[0m:\u{1b}[35m10\u{1b}[0m\n\nBacktrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.\nRun with RUST_BACKTRACE=full to include source snippets."
    Location: /home/runner/work/namada/namada/crates/apps/src/lib/cli/context.rs:246

  • Succeed when rpc without "http://" -
    namadac --chain-id shielded-expedition.88f17d1d14 --base-dir /home/namadexer/.local/share/namada balance --node 94.130.90.47:26657 --owner se_wallet
    naan: 15

  • Crash when rpc with "http://" -
    namadac --base-dir /home/namadexer/.local/share/namada
    ibc-transfer
    --amount 1
    --source se_wallet
    --receiver osmo1wdj0pt7qmphdj6wermp0kq97rkwnxnzlvpsz42
    --token naan
    --channel-id channel-42
    --node http://94.130.90.47:26657
    --memo tpknam1qqjgef9zsd0gsyqn3af9nrgxyhapef3cjn5cyxpjcjgtq60de6502p8rf8h
    The application panicked (crashed).
    Message: called Result::unwrap() on an Err value: "Invalid Tendermint address: \n 0: \u{1b}[91merror parsing data: invalid address scheme: "http://94.130.90.47:26657"\u{1b}[0m\n\nLocation:\n \u{1b}[35m/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/flex-error-0.4.4/src/tracer_impl/eyre.rs\u{1b}[0m:\u{1b}[35m10\u{1b}[0m\n\nBacktrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.\nRun with RUST_BACKTRACE=full to include source snippets."
    Location: /home/runner/work/namada/namada/crates/apps/src/lib/cli/context.rs:246

  • Succeed when rpc without "http://" -
    namadac --base-dir /home/namadexer/.local/share/namada
    ibc-transfer
    --amount 1
    --source se_wallet
    --receiver osmo1wdj0pt7qmphdj6wermp0kq97rkwnxnzlvpsz42
    --token naan
    --channel-id channel-42
    --node 94.130.90.47:26657
    --memo tpknam1qqjgef9zsd0gsyqn3af9nrgxyhapef3cjn5cyxpjcjgtq60de6502p8rf8h
    Enter your decryption password:
    Transaction added to mempool.
    Wrapper transaction hash: 879DF7CC48070392E128ED85B69BA1B26E98CE3A6B6CAA28D1BA88DF5F9CE3B7
    Inner transaction hash: 82F5A5C3A4094DAD43E0F158B9EFDB8788D2BC181DBCC42CEFC847D0A4987FE3
    Wrapper transaction accepted at height 14237. Used 26 gas.
    Waiting for inner transaction result...
    Transaction was successfully applied at height 14238. Used 6193 gas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant