Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boot-service): execute on later Android versions #17154

Merged
merged 2 commits into from
Sep 28, 2024
Merged

fix(boot-service): execute on later Android versions #17154

merged 2 commits into from
Sep 28, 2024

Conversation

david-allison
Copy link
Member

Fixes

Approach

Don't use a legacy check

How Has This Been Tested?

On my S21 (Android 14), logs now show the Boot Service executing

Learning (optional, can help others)

Need more tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
refactor(permissions): rename method
347043a 
`hasStorageAccessPermission` -> `hasLegacyStorageAccessPermission`

We should prefer `grantedStoragePermissions`

Issue 17153
@david-allison
fix(boot-service): execute on later Android versions
f44530b 
Fixes the log message:

`Boot Service did not execute - no permissions`

We were checking for legacy permissions which no longer existed

Fixes 17153
mikehardy
mikehardy approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mikehardy mikehardy added this pull request to the merge queue Sep 28, 2024
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Sep 28, 2024
Merged via the queue into ankidroid:main with commit f790113 Sep 28, 2024
12 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Sep 28, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 28, 2024
@david-allison david-allison deleted the 17153 branch September 29, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19 release
Development

Successfully merging this pull request may close these issues.

"Boot Service did not execute - no permissions"
2 participants
@david-allison @mikehardy